-
Notifications
You must be signed in to change notification settings - Fork 111
fix: restore proper license headers for third-party code #4134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ibution This commit addresses license compliance issues identified during an audit: 1. Restored original MIT license headers for third-party code: - pyright-language-service/src/*.ts (TypeFox monaco-languageclient) - common/workflow-operator/src/main/scala/com/kjetland/** (mbknor-jackson-jsonschema) - frontend/src/app/common/formly/array.type.ts (Google Angular) 2. Updated LICENSE file with proper third-party attribution section including full MIT license text for each bundled dependency 3. Updated .licenserc.yaml to exclude third-party files from Apache license header checking 4. Added sbt-license-report plugin (v1.7.0) for automated dependency license tracking and compliance auditing The third-party code (all MIT licensed, Category A) is compatible with Apache License 2.0 but requires proper attribution per Apache policy.
Remove pyright-language-service license header changes as they are already addressed in PR apache#4132. This commit now focuses only on: - mbknor-jackson-jsonschema (MIT license attribution) - Angular array.type.ts (MIT license attribution) - sbt-license-report plugin for dependency tracking
|
While this fixes some of the issues, I still think there are more remaining. I would also suggest that this task not be done via Claude or other LLMs. I don't think it's the right tool for the job. Using a script that an LLM might generate could be good, but there is no easy way to check the validity of the output an LLM would generate in this task. In fact it's exceedingly hard to validate this task, and easy to mistake it for being done correctly, as we have seen. Therefore the method in which it is done is important to scrutinize and have a high degree of confidence in. My method so far has been to look at the diff of the change that added all of the ASF headers (and inadvertently changed some), and look carefully at any instance where lines were removed instead of added. There are not many of these. Each of those should be scrutinized and marked as either appropriate or mistaken. |
Thank you for your review! I will manually check files and make the fix complete. I have one question regarding the location of attribution. Quoting from https://infra.apache.org/licensing-howto.html#permissive-deps,
Seems the attribution should still be put in LICENSE, not |
What changes were proposed in this PR?
The third-party code (all MIT licensed, Category A) is compatible with Apache License 2.0 but requires proper attribution per Apache policy. This PR addresses license compliance issues identified during an audit:
Restored original MIT license headers for third-party code:
Updated LICENSE file with proper third-party attribution section including full MIT license text for each bundled dependency
Updated .licenserc.yaml to exclude third-party files from Apache license header checking
Added sbt-license-report plugin for automated dependency license tracking and compliance auditing
Any related issues, documentation, discussions?
Closes #4135. Related to #4132.
How was this PR tested?
Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude code.