Skip to content

[MINOR] Federated timeout#2179

Closed
Baunsgaard wants to merge 4 commits intoapache:mainfrom
Baunsgaard:FederatedTimeout
Closed

[MINOR] Federated timeout#2179
Baunsgaard wants to merge 4 commits intoapache:mainfrom
Baunsgaard:FederatedTimeout

Conversation

@Baunsgaard
Copy link
Contributor

This commit reduce the timeout for federated tests, and enforce the timeout on federated requests. Previously we had some test cases that would infinitely run, and therefore we would not be able to decipher the log messages (because nothing would be written). This commit change it by enforcing a strict 16 seconds execution time for a single federated requests and a 1 day timeout for a default federated requests.
Previously some operations did use the federated timeout. However, it was not enforced in critical places.

This commit reduce the timeout for federated tests, and enforce the timeout on federated requests. Previously we had some test cases that would infinitely run, and therefore we would not be able to decipher the log messages (because nothing would be written). This commit change it by enforcing a strict 16 seconds execution time for a single federated requests and a 1 day timeout for a default federated requests.
Previously some operations did use the federated timeout. However, it was not enforced in critical places.
@codecov
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 71.86%. Comparing base (15c6abe) to head (3acbab4).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...untime/controlprogram/federated/FederationMap.java 42.85% 8 Missing and 4 partials ⚠️
...he/sysds/runtime/compress/cocode/CoCodeGreedy.java 62.50% 2 Missing and 1 partial ⚠️
...instructions/cp/ParamservBuiltinCPInstruction.java 40.00% 2 Missing and 1 partial ⚠️
...MultiReturnParameterizedBuiltinFEDInstruction.java 77.77% 2 Missing ⚠️
...ache/sysds/runtime/compress/lib/CLALibCompAgg.java 95.83% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2179      +/-   ##
============================================
+ Coverage     71.84%   71.86%   +0.01%     
- Complexity    44425    44443      +18     
============================================
  Files          1445     1445              
  Lines        168202   168259      +57     
  Branches      32832    32847      +15     
============================================
+ Hits         120853   120913      +60     
+ Misses        38052    38048       -4     
- Partials       9297     9298       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant