Skip to content

Adding builtin function for SQRT Matrix #2178

Closed
Mantany wants to merge 10 commits intoapache:mainfrom
get4flo:main
Closed

Adding builtin function for SQRT Matrix #2178
Mantany wants to merge 10 commits intoapache:mainfrom
get4flo:main

Conversation

@Mantany
Copy link

@Mantany Mantany commented Jan 12, 2025

This PR will close SYSTEMDS-3258 Builtin for matrix square root

@Mantany
Copy link
Author

Mantany commented Jan 12, 2025

@codecov
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.86%. Comparing base (15c6abe) to head (d35ff44).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...apache/sysds/parser/BuiltinFunctionExpression.java 80.00% 1 Missing and 1 partial ⚠️
...ache/sysds/runtime/matrix/data/LibCommonsMath.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2178      +/-   ##
============================================
+ Coverage     71.84%   71.86%   +0.01%     
- Complexity    44425    44441      +16     
============================================
  Files          1445     1445              
  Lines        168202   168220      +18     
  Branches      32832    32834       +2     
============================================
+ Hits         120853   120891      +38     
+ Misses        38052    38041      -11     
+ Partials       9297     9288       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mboehm7
Copy link
Contributor

mboehm7 commented Jan 16, 2025

LGTM - thanks for the patch everybody. During the merge I consolidated the builtin function names, added the missing dml documentation, moved the strategy selection into the dml-bodied builtin function, and vectorized a number of loops in the dml-bodied builtin function, and fixed the check for identity matrices.

@mboehm7 mboehm7 closed this in 06ad1b5 Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants