Adding builtin function for SQRT Matrix #2178
Closed
Mantany wants to merge 10 commits intoapache:mainfrom
Closed
Conversation
…is branch, cleanup
Author
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2178 +/- ##
============================================
+ Coverage 71.84% 71.86% +0.01%
- Complexity 44425 44441 +16
============================================
Files 1445 1445
Lines 168202 168220 +18
Branches 32832 32834 +2
============================================
+ Hits 120853 120891 +38
+ Misses 38052 38041 -11
+ Partials 9297 9288 -9 ☔ View full report in Codecov by Sentry. |
Contributor
|
LGTM - thanks for the patch everybody. During the merge I consolidated the builtin function names, added the missing dml documentation, moved the strategy selection into the dml-bodied builtin function, and vectorized a number of loops in the dml-bodied builtin function, and fixed the check for identity matrices. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will close SYSTEMDS-3258 Builtin for matrix square root