Open
Conversation
Contributor
|
Hi @dpol1 thanks for the PR ! Can you check the pipeline status? Guess it needs auto formatting. Thanks |
Contributor
Author
|
Oops, my bad 😅 |
dpol1
force-pushed
the
fix/solr-10-migration
branch
from
956a76f to
721d892
Compare
rzo1
approved these changes
Mar 21, 2026
Contributor
rzo1
left a comment
rzo1
left a comment
There was a problem hiding this comment.
For me, it looks good but I am not deep into SOLR.
Contributor
|
Thanks for the PR, @dpol1 |
mvolikas
requested changes
Mar 22, 2026
| "--name", | ||
| collectionName, | ||
| "-n", | ||
| "--conf-name", |
Contributor
There was a problem hiding this comment.
Some options (like --conf-name) are not documented in the Solr Control Script Reference, but are shown when running bin/solr create --help so I guess are ok to use.
external/solr/src/main/java/org/apache/stormcrawler/solr/SolrConnection.java
Outdated
Show resolved
Hide resolved
external/solr/src/main/java/org/apache/stormcrawler/solr/SolrConnection.java
Outdated
Show resolved
Hide resolved
- Drop pseudo-async CompletableFuture.runAsync() around blocking cloudClient.request(). - Use NIO-based LBAsyncSolrClient.requestAsync() for Solr 10. - Route writes via LBSolrClient.Endpoint built from leader baseUrl/coreName. - Access CloudHttp2SolrClient#getLbClient() via explicit cast, with a note on potential SolrJ API changes.
Contributor
|
Thanks for the changes @dpol1. Unfortunately I'm currently sick, so I'll be able to review earliest tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1831