Allow per-component configuration in Flux topology#8783
Open
GGraziadei wants to merge 1 commit into
Open
Conversation
reiabreu
reviewed
Jun 4, 2026
| } | ||
|
|
||
| @Test | ||
| public void testComponentConfig() throws Exception { |
Contributor
There was a problem hiding this comment.
Can we make a test where we are overriding topology-level configs?
Contributor
Author
There was a problem hiding this comment.
Hi, thank you for the comment. I totally agree, for coverage tree convenience, I am not adding a new test case, but compacting the scenario you proposed in this test case.
Contributor
|
Nice, well-scoped feature that rides on Storm's native component-config mechanism.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Add per-component configuration in the flux topology def grammar.
How was the change tested
Fix Flux support per-component configuration in
BoltDefandSpoutDef#8710