[SPARK-57223][SQL]Wrong display of column or struct field containing a dot or space in error messages#56294
Draft
jiwen624 wants to merge 2 commits into
Draft
Conversation
…special-char column names Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ld names containing dots or spaces `DataTypeErrorsBase.toSQLId(String)` was calling `AttributeNameParser.parseAttributeName` which treats the input as SQL text and splits on dots, so a stored column name like `job.title` was rendered as `\`job\`.\`title\`` instead of `\`job.title\`` in error messages. Fix the String overload to delegate to `toSQLId(Seq(parts))`, treating the input as a single verbatim identifier. Pre-formatted callers (E1-E6) that relied on the old re-parsing behaviour are corrected: `ResolvedTable.name` used directly, `column.quoted` replaced with `column.toImmutableArraySeq`, `col.name.quoted` replaced with `col.name`, `FunctionIdentifier`/`TableIdentifier` use `nameParts`, and the JDBC table identifier uses `ident.namespace().toSeq :+ ident.name()`. Table display names in `TableOutputResolver` error functions are pre-formatted by callers and passed through as-is. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jiwen624
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?