[SPARK-56469][SQL][TESTS] BufferedRowsReader lifecycle hardening#55336
Closed
peter-toth wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-56469][SQL][TESTS] BufferedRowsReader lifecycle hardening#55336peter-toth wants to merge 1 commit intoapache:masterfrom
BufferedRowsReader lifecycle hardening#55336peter-toth wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
11a1fb8 to
d02d82a
Compare
dongjoon-hyun
approved these changes
Apr 14, 2026
Member
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @peter-toth .
Member
|
Currently |
Contributor
Author
|
I've just retriggered it. |
Member
|
Merged to master for Apache Spark 4.2.0. |
Contributor
Author
|
Thank you @dongjoon-hyun! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Extracted from #55116.
The test-framework reader in
InMemoryBaseTablenow tracks a closed flag and throwsIllegalStateExceptionfor reads, double-closes, or metric fetches on a closed reader. This ensures future tests catch reader lifecycle bugs that were previously hidden by the noopclose().Why are the changes needed?
Improve test framework.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UTs.
Was this patch authored or co-authored using generative AI tooling?
No.