Skip to content

Comments

[SPARK-55637][SQL][TESTS] Generalize postgres-krb-setup.sh to find config files#54423

Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-55637
Closed

[SPARK-55637][SQL][TESTS] Generalize postgres-krb-setup.sh to find config files#54423
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-55637

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Feb 23, 2026

What changes were proposed in this pull request?

This PR aims to generalize postgres-krb-setup.sh to find config files instead of using static locations.

Why are the changes needed?

To improve PostgresKrbIntegrationSuite to handle different PostgreSQL image via POSTGRES_DOCKER_IMAGE_NAME.

Currently, PostgresKrbIntegrationSuite fails for other PostgreSQL images.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

Generated-by: Gemini 3.1 Pro (High) on Antigravity

@dongjoon-hyun
Copy link
Member Author

Thank you, @peter-toth ! Merged to master.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-55637 branch February 23, 2026 15:19
@dongjoon-hyun
Copy link
Member Author

I'm going to backport this test PR to help the maintenance of old release branches.

dongjoon-hyun added a commit that referenced this pull request Feb 23, 2026
…config files

### What changes were proposed in this pull request?

This PR aims to generalize `postgres-krb-setup.sh` to find config files instead of using static locations.

### Why are the changes needed?

To improve `PostgresKrbIntegrationSuite` to handle different PostgreSQL image via `POSTGRES_DOCKER_IMAGE_NAME`.

Currently, `PostgresKrbIntegrationSuite` fails for other `PostgreSQL` images.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

Generated-by: `Gemini 3.1 Pro (High)` on `Antigravity`

Closes #54423 from dongjoon-hyun/SPARK-55637.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 920a401)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun added a commit that referenced this pull request Feb 23, 2026
…config files

### What changes were proposed in this pull request?

This PR aims to generalize `postgres-krb-setup.sh` to find config files instead of using static locations.

### Why are the changes needed?

To improve `PostgresKrbIntegrationSuite` to handle different PostgreSQL image via `POSTGRES_DOCKER_IMAGE_NAME`.

Currently, `PostgresKrbIntegrationSuite` fails for other `PostgreSQL` images.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

Generated-by: `Gemini 3.1 Pro (High)` on `Antigravity`

Closes #54423 from dongjoon-hyun/SPARK-55637.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 920a401)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 27b7268)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@dongjoon-hyun
Copy link
Member Author

Landed to branch-4.1 and 4.0, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants