Skip to content

[SPARK-55638][SPARK][Geo][SQL] Refactor WKT serialization in GeometryModel#54414

Closed
uros-db wants to merge 1 commit intoapache:masterfrom
uros-db:geo-model-toString
Closed

[SPARK-55638][SPARK][Geo][SQL] Refactor WKT serialization in GeometryModel#54414
uros-db wants to merge 1 commit intoapache:masterfrom
uros-db:geo-model-toString

Conversation

@uros-db
Copy link
Contributor

@uros-db uros-db commented Feb 21, 2026

What changes were proposed in this pull request?

Adds a public toWKT method in GeometryModel to separate concerns from toString.

Why are the changes needed?

This way, callers can have a clearly defined way to obtain the WKT geo value representation.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Updates all WKT writer tests to call toWKT() directly.

Was this patch authored or co-authored using generative AI tooling?

No.

@uros-db uros-db marked this pull request as ready for review February 23, 2026 06:30
@uros-db uros-db changed the title [DRAFT][SPARK][Geo][SQL] Refactor WKT serialization in GeometryModel [SPARK-55638][SPARK][Geo][SQL] Refactor WKT serialization in GeometryModel Feb 23, 2026
Copy link
Contributor Author

@uros-db uros-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szehon-ho Please review, with respect to your comment from another PR. cc @cloud-fan

@cloud-fan
Copy link
Contributor

thanks, merging to master!

@cloud-fan cloud-fan closed this in 8b5c1bb Feb 23, 2026
Copy link
Member

@szehon-ho szehon-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

late lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants