-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-54065][PYTHON][TESTS][FOLLOWUP] Remove unused import module from test_python_datasource.py
#52970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_python_datasource.py
test_python_datasource.pytest_python_datasource.py
Member
Author
LuciferYang
approved these changes
Nov 10, 2025
Contributor
LuciferYang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM
zhengruifeng
approved these changes
Nov 10, 2025
zhengruifeng
pushed a commit
that referenced
this pull request
Nov 10, 2025
…om `test_python_datasource.py` ### What changes were proposed in this pull request? This PR aims to recover CI by removing `import sys` from `test_python_datasource.py` After #52967, CI consistently fails because `sys` is no longer used. ### Why are the changes needed? To recover CI. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52970 from sarutak/followup-SPARK-54065. Authored-by: Kousuke Saruta <sarutak@amazon.co.jp> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org> (cherry picked from commit 8cc76fe) Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Contributor
|
thanks for the quick fix. |
Member
|
Oh. Thank you so much for the quick follow-up fix and merging, @sarutak and @zhengruifeng . |
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 22, 2025
…om `test_python_datasource.py` ### What changes were proposed in this pull request? This PR aims to recover CI by removing `import sys` from `test_python_datasource.py` After apache#52967, CI consistently fails because `sys` is no longer used. ### Why are the changes needed? To recover CI. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52970 from sarutak/followup-SPARK-54065. Authored-by: Kousuke Saruta <sarutak@amazon.co.jp> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…om `test_python_datasource.py` ### What changes were proposed in this pull request? This PR aims to recover CI by removing `import sys` from `test_python_datasource.py` After apache#52967, CI consistently fails because `sys` is no longer used. ### Why are the changes needed? To recover CI. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52970 from sarutak/followup-SPARK-54065. Authored-by: Kousuke Saruta <sarutak@amazon.co.jp> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to recover CI by removing
import sysfromtest_python_datasource.pyAfter #52967, CI consistently fails because
sysis no longer used.Why are the changes needed?
To recover CI.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
GA.
Was this patch authored or co-authored using generative AI tooling?
No.