Backport Filter changes for SOLR-18044 and SOLR-18046#4105
Merged
gus-asf merged 2 commits intoapache:branch_10xfrom Feb 5, 2026
Merged
Backport Filter changes for SOLR-18044 and SOLR-18046#4105gus-asf merged 2 commits intoapache:branch_10xfrom
gus-asf merged 2 commits intoapache:branch_10xfrom
Conversation
… wrapping operations (apache#3997) (cherry picked from commit 0538d17)
Contributor
|
Unlike the title of this PR, please remember to give this a proper commit title -- one that doesn't say "backport" and one that, at a glance, could get a theme/gist. I've seen this mistake by Eric recently... so easy to hit the green buttons and the next thing you know, it's there forever. |
Contributor
|
e.g. |
Contributor
Author
|
I did have that in mind (this time). :) |
Contributor
Author
|
However, I do think it is worth mentioning that it was a backport in the message because sometimes that implies merging which is a potential source of bugs. |
Contributor
Author
|
Test failures are inconsistent and appear unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18044
https://issues.apache.org/jira/browse/SOLR-18046
Backporting RequiredSolrRequestFilter and RateLimitFilter to 10.x