Support global.imagePullSecrets in solr-operator helm chart (#338)#832
Open
mattiasbpersson wants to merge 1 commit into
Open
Support global.imagePullSecrets in solr-operator helm chart (#338)#832mattiasbpersson wants to merge 1 commit into
mattiasbpersson wants to merge 1 commit into
Conversation
Adds global.imagePullSecrets to the solr-operator deployment pod spec.
The existing image.imagePullSecret was rendered inside containers[],
which is not a valid Kubernetes field and is silently ignored.
This places imagePullSecrets at the correct pod spec level and supports
both Kubernetes-native format ([{name: "secret"}]) and plain strings.
Closes apache#338
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
global.imagePullSecretssupport to the solr-operator helm chart deployment.The existing
image.imagePullSecretfield is rendered insidecontainers[]in the deployment template, which is not a valid Kubernetes pod spec field. Kubernetes silently ignores it, so pull secrets are never applied to the operator pod. This makes it impossible to deploy the solr-operator from a private registry.This PR adds
global.imagePullSecretsat the pod spec level (spec.template.spec.imagePullSecrets), consistent with how the solr helm chart already handles it.Supports both formats:
[{name: "my-secret"}]["my-secret"]Changes
values.yaml— Addedglobal.imagePullSecretsdefaulttemplates/deployment.yaml— RenderimagePullSecretsat pod spec levelChart.yaml— Changelog entryREADME.md— Documentation entryRelated