Skip to content

Bugfix/sling 13065 rebase string out of bounds exception #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rubnig wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugfix/sling 13065 rebase string out of bounds exception #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d98301c
SLING-13065 Add test cases for StringIndexOutOfBounds bug
Jan 21, 2026
d50e5bc
SLING-13065 Don't try to further process the resource path, if there …
Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/apache/sling/api/uri/SlingUriBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ public SlingUriBuilder rebaseResourcePath() {
selectors.clear();
extension = null;
suffix = null;
if (availableResourcePath.length() == path.length()) {
if (availableResourcePath.length() == path.length() || !path.contains(CHAR_DOT)) {
resourcePath = availableResourcePath;
} else {
setPathWithDefinedResourcePosition(path, availableResourcePath.length());
Expand Down
15 changes: 15 additions & 0 deletions src/test/java/org/apache/sling/api/uri/SlingUriTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
package org.apache.sling.api.uri;

import java.net.URI;
import java.net.URISyntaxException;
import java.util.List;
import java.util.function.Consumer;

Expand Down Expand Up @@ -1024,6 +1025,20 @@ public void testHostWithoutSchemeAndQueryAndPath() {
assertEquals("//sling.apache.org", testUri.toUri().toASCIIString());
}

@Test
public void testWithSchemeAndMappedPathWithSlashAsLastCharacter() {
SlingUri testUri = SlingUriBuilder.parse("https://sling.apache.org/apidocs/sling12/", resolver)
.build();
assertEquals("https://sling.apache.org/apidocs/sling12", testUri.toUri().toASCIIString());
}

@Test
public void testWithSchemeAndMappedPathWithSlashAsLastCharacterCreateFromUri() throws URISyntaxException {
URI input = new URI("https://sling.apache.org/apidocs/sling12/");
SlingUri testUri = SlingUriBuilder.createFrom(input, resolver).build();
assertEquals("https://sling.apache.org/apidocs/sling12", testUri.toUri().toASCIIString());
}

// -- helper methods
public static void testUri(
String testUri,
Expand Down