Fix missing AND keyword in JDBCEBPFProfilingTaskDAO.getTaskRecord() SQL#13789
Merged
wu-sheng merged 4 commits intoapache:masterfrom Apr 4, 2026
Merged
Conversation
e7f0a48 to
a203816
Compare
The SQL query in getTaskRecord() was missing the 'and' keyword between the table_column and logical_id conditions, producing invalid SQL like: WHERE table_column = ?logical_id = ? which causes a syntax error on every invocation.
Verify that the generated SQL contains a valid WHERE clause with the AND keyword between the table_column and logical_id conditions, and that the id parameter is correctly bound.
a203816 to
bf8eea0
Compare
mrproliu
previously approved these changes
Apr 4, 2026
wu-sheng
approved these changes
Apr 4, 2026
Member
|
@currenjin Thanks for finding these bugs. Curiously, are you going to deploy skywalking in some product env by using SQL DB? As I noticed, you are focusing on SQL-kind things. |
Contributor
Author
|
@wu-sheng Thanks for asking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix missing
andkeyword inJDBCEBPFProfilingTaskDAO.getTaskRecord()CHANGESlog.JDBCEBPFProfilingTaskDAO.getTaskRecord()builds a SQL query with two WHERE conditions (table_columnandlogical_id), but theandkeyword between them was missing.The generated SQL looked like:
This is a SQL syntax error. Every call to
getTaskRecord()fails at the database level.Fix
Added the missing
andbetween the two conditions: