Skip to content

Remove GroupBy.field_name from BanyanDB MeasureQuery request building#13786

Merged
wu-sheng merged 1 commit intoapache:masterfrom
currenjin:fix/remove-groupby-field-name-from-measure-query
Apr 3, 2026
Merged

Remove GroupBy.field_name from BanyanDB MeasureQuery request building#13786
wu-sheng merged 1 commit intoapache:masterfrom
currenjin:fix/remove-groupby-field-name-from-measure-query

Conversation

@currenjin
Copy link
Copy Markdown
Contributor

What this PR does

Phase 1 of the staged removal described in #13779.

QueryRequest.GroupBy.field_name is not used by BanyanDB's query execution path. BanyanDB groups by tag_projection, not by field_name. Sending this field is misleading and should be removed.

This PR removes the single groupByBuilder.setFieldName(this.aggregation.fieldName) call in MeasureQuery.build(), so the GroupBy message now only carries tag_projection.

The Aggregation.field_name and Top.field_name fields are unrelated (they specify which field to aggregate on / sort by) and are intentionally left unchanged.

Subsequent steps

  • Phase 2: Remove GroupBy.field_name from the client proto repo.
  • Phase 3: Remove the field from BanyanDB server.

Related

Closes #13779 (Phase 1)

@wu-sheng wu-sheng added the chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. label Apr 3, 2026
@wu-sheng wu-sheng added this to the 10.5.0 milestone Apr 3, 2026
@wu-sheng wu-sheng requested a review from hanahmily April 3, 2026 00:51
@wu-sheng wu-sheng merged commit 2f652be into apache:master Apr 3, 2026
413 of 421 checks passed
@currenjin currenjin deleted the fix/remove-groupby-field-name-from-measure-query branch April 3, 2026 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate and remove QueryRequest.GroupBy.field_name in staged rollout across repos

3 participants