Skip to content

Configure GitHub workflows to use concurrency cancel-in-progress for#10445

Open
apupier wants to merge 1 commit into
apache:developfrom
apupier:addConcurrencyCancelInProgressForGitHubWorkflows
Open

Configure GitHub workflows to use concurrency cancel-in-progress for#10445
apupier wants to merge 1 commit into
apache:developfrom
apupier:addConcurrencyCancelInProgressForGitHubWorkflows

Conversation

@apupier
Copy link
Copy Markdown

@apupier apupier commented Jun 8, 2026

pull requests

see recommended best practices at Apache
https://cwiki.apache.org/confluence/pages/viewpage.action?spaceKey=INFRA&title=GitHub+Actions+Recommended+Practices

Which Issue(s) This PR Fixes

  • Fixes #issue_id

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.97%. Comparing base (82a6a78) to head (16443ba).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10445      +/-   ##
=============================================
- Coverage      48.05%   47.97%   -0.08%     
+ Complexity     13311    13286      -25     
=============================================
  Files           1377     1377              
  Lines         100632   100632              
  Branches       12995    12995              
=============================================
- Hits           48359    48279      -80     
- Misses         46351    46409      +58     
- Partials        5922     5944      +22     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@oss-taishan-ai oss-taishan-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by github-manager-bot

Summary

This PR adds concurrency configuration to all GitHub workflow files, enabling cancel-in-progress for pull request events to avoid unnecessary CI resource consumption.

Findings

  • [Info] .github/workflows/bazel.yml:11-13 — Correct concurrency configuration with proper group naming and conditional cancel-in-progress.
  • [Info] .github/workflows/codeql_analysis.yml:10-12 — Consistent configuration applied.
  • [Info] .github/workflows/coverage.yml:8-10 — Correct implementation.
  • [Info] .github/workflows/integration-test.yml:8-11 — Proper configuration.
  • [Info] .github/workflows/license-checker.yaml:25-27 — Correct implementation.
  • [Info] .github/workflows/maven.yaml:8-11 — Consistent with other workflows.
  • [Info] .github/workflows/misspell_check.yml:8-10 — Correct configuration.

Suggestions

The implementation follows Apache INFRA recommended best practices. The concurrency group naming convention (${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}) correctly isolates PR builds while allowing branch builds to run independently. The conditional cancel-in-progress (only for pull_request events) is appropriate.

Verdict

Approved — Clean CI optimization following Apache best practices.


Automated review by github-manager-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants