Skip to content

[ISSUE #10181] Some minor fixes in PopConsumerService#10182

Merged
lizhimins merged 1 commit intoapache:developfrom
lizhimins:zhimin/issue-10181
Mar 23, 2026
Merged

[ISSUE #10181] Some minor fixes in PopConsumerService#10182
lizhimins merged 1 commit intoapache:developfrom
lizhimins:zhimin/issue-10181

Conversation

@lizhimins
Copy link
Copy Markdown
Member

Which Issue(s) This PR Fixes

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.82%. Comparing base (ebf1595) to head (cf03817).

Files with missing lines Patch % Lines
...apache/rocketmq/broker/pop/PopConsumerService.java 60.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10182      +/-   ##
=============================================
- Coverage      48.94%   48.82%   -0.12%     
+ Complexity     13389    13358      -31     
=============================================
  Files           1373     1373              
  Lines          99924    99924              
  Branches       12908    12908              
=============================================
- Hits           48904    48790     -114     
- Misses         45097    45193      +96     
- Partials        5923     5941      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@qianye1001 qianye1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhimins lizhimins merged commit e100743 into apache:develop Mar 23, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Some minor fixes in PopConsumerService

4 participants