[improve][admin] Add support for PIP-431: Creation and Last Publish Timestamps #1451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements PIP-431 support in the Go client admin API by adding topic creation and last publish timestamps to topic statistics. The changes enable clients to track when topics were created and when messages were last published to them.
- Added
TopicCreationTimeStampandLastPublishTimestampfields to bothTopicStatsandPartitionedTopicStatsstructs - Implemented comprehensive integration tests to verify timestamp behavior for both regular and partitioned topics
- Both fields use
omitemptyJSON tags to maintain backward compatibility
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pulsaradmin/pkg/utils/data.go | Added TopicCreationTimeStamp and LastPublishTimestamp fields to TopicStats and PartitionedTopicStats structs with appropriate JSON tags |
| pulsaradmin/pkg/admin/topic_test.go | Added integration tests TestTopicStatsTimestamps and TestPartitionedTopicStatsTimestamps to verify timestamp behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RobertIndie
approved these changes
Dec 17, 2025
Member
RobertIndie
left a comment
RobertIndie
left a comment
There was a problem hiding this comment.
PTAL at the copilot's comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Implement PIP-431 support in the Go client admin API. This adds and to topic statistics.
Modifications
Verifying this change
This change is covered by the new integration tests.