Skip to content

feat: add pouchdb-adapter-nodesqlite#9223

Open
AlbaHerrerias wants to merge 1 commit intoapache:masterfrom
neighbourhoodie:node-sqlite-adapter
Open

feat: add pouchdb-adapter-nodesqlite#9223
AlbaHerrerias wants to merge 1 commit intoapache:masterfrom
neighbourhoodie:node-sqlite-adapter

Conversation

@AlbaHerrerias
Copy link
Copy Markdown
Contributor

Overview

Hello! 👋

We are from the Neighbourhoodie Software, the implementation partner of the STA Bug Resilience Program. This work is part of our agreed 'Milestone 1. Deprecate and Remove LevelDB Subsystem'.

This PR introduces pouchdb-adapter-nodesqlite, that internally uses Node.js's native SQLite module as its persistence layer. The adapter is based on the original pouchdb-adapter-websql-core, which is compatible with SQLite, and used to be part of PouchDB and is still part of the repository history. Re-incorporating it should be fine and covered by Dale’s and Nolan’s respective grants to the ASF.

The adapter depends on node-websql, which has been forked and adapted from its original. node-websql is all Nolan’s work and we will have to obtain a new grant if we wanted to integrate it into the Apache PouchDB's source code, so for now we have made it a forked dependency.

This represents the first step on deprecating and removing the LevelDB Subsystem that PouchDB depends on and wants to move away from.

Thank you

Testing recommendations

As usual. A new job has been introduced to test this adapter in GitHub Actions, as Node.js's SQLite module was introduced in version 22.5.0 and the other jobs are being tested in 20 as well.

Related Issues or Pull Requests

Related #9163

Checklist

  • I am not a bot
  • This is my own work, I did not use AI, LLM's or similar technology for code or docs generation
  • Code is written and works correctly
  • Changes are covered by tests
  • Documentation changes were made in the docs folder

Co-Authored-By: Julia Krüger <juliakbln@gmail.com>
Co-Authored-By: Jan Lehnardt <jan@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant