feat: add pouchdb-adapter-nodesqlite#9223
Open
AlbaHerrerias wants to merge 1 commit intoapache:masterfrom
Open
feat: add pouchdb-adapter-nodesqlite#9223AlbaHerrerias wants to merge 1 commit intoapache:masterfrom
AlbaHerrerias wants to merge 1 commit intoapache:masterfrom
Conversation
Co-Authored-By: Julia Krüger <juliakbln@gmail.com> Co-Authored-By: Jan Lehnardt <jan@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Hello! 👋
We are from the Neighbourhoodie Software, the implementation partner of the STA Bug Resilience Program. This work is part of our agreed 'Milestone 1. Deprecate and Remove LevelDB Subsystem'.
This PR introduces
pouchdb-adapter-nodesqlite, that internally uses Node.js's native SQLite module as its persistence layer. The adapter is based on the originalpouchdb-adapter-websql-core, which is compatible with SQLite, and used to be part of PouchDB and is still part of the repository history. Re-incorporating it should be fine and covered by Dale’s and Nolan’s respective grants to the ASF.The adapter depends on
node-websql, which has been forked and adapted from its original.node-websqlis all Nolan’s work and we will have to obtain a new grant if we wanted to integrate it into the Apache PouchDB's source code, so for now we have made it a forked dependency.This represents the first step on deprecating and removing the LevelDB Subsystem that PouchDB depends on and wants to move away from.
Thank you
Testing recommendations
As usual. A new job has been introduced to test this adapter in GitHub Actions, as Node.js's SQLite module was introduced in version 22.5.0 and the other jobs are being tested in 20 as well.
Related Issues or Pull Requests
Related #9163
Checklist
docsfolder