Skip to content

Fix default HTTPS protocol to use HttpsSegmentFetcher#17675

Open
ilamhs wants to merge 1 commit intoapache:masterfrom
ilamhs:fix-https-segment-fetcher-routing
Open

Fix default HTTPS protocol to use HttpsSegmentFetcher#17675
ilamhs wants to merge 1 commit intoapache:masterfrom
ilamhs:fix-https-segment-fetcher-routing

Conversation

@ilamhs
Copy link
Copy Markdown
Contributor

@ilamhs ilamhs commented Feb 10, 2026

The default segment fetcher for HTTPS protocol incorrectly returns HttpSegmentFetcher instead of HttpsSegmentFetcher. This means SSL configuration options in HttpsSegmentFetcher (including the renewable SSL context added in #17315) are never used for default HTTPS fetches.

This change:

  • Adds a dedicated HTTPS_SEGMENT_FETCHER instance
  • Initializes it alongside other default fetchers
  • Returns it for HTTPS protocol in getSegmentFetcher()
  • Updates javadoc and test to reflect correct behavior

The default segment fetcher for HTTPS protocol incorrectly returns
HttpSegmentFetcher instead of HttpsSegmentFetcher. This means SSL
configuration options in HttpsSegmentFetcher (including the renewable
SSL context added in apache#17315) are never used for default HTTPS fetches.

This change:
- Adds a dedicated HTTPS_SEGMENT_FETCHER instance
- Initializes it alongside other default fetchers
- Returns it for HTTPS protocol in getSegmentFetcher()
- Updates javadoc and test to reflect correct behavior
@ilamhs ilamhs changed the title Fix default HTTPS protocol to use HttpsSegmentFetcher [bugfix] Fix default HTTPS protocol to use HttpsSegmentFetcher Feb 10, 2026
@ilamhs ilamhs changed the title [bugfix] Fix default HTTPS protocol to use HttpsSegmentFetcher Fix default HTTPS protocol to use HttpsSegmentFetcher Feb 10, 2026
Copy link
Copy Markdown
Contributor

@AlexanderKM AlexanderKM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 10, 2026

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
12303 1 12302 45
View the top 3 failed test(s) by shortest run time
org.apache.pinot.controller.helix.core.minion.PinotTaskManagerDistributedLockingTest::testForceReleaseLockDuringTaskExecution
Stack Traces | 18.5s run time
Both createTask calls should have generated tasks expected [2] but found [3]
org.apache.pinot.controller.helix.core.minion.PinotTaskManagerDistributedLockingTest::testForceReleaseLockDuringTaskExecution
Stack Traces | 20.8s run time
Both createTask calls should have generated tasks expected [2] but found [3]
org.apache.pinot.integration.tests.TlsIntegrationTest::testRealtimeSegmentUploadDownload
Stack Traces | 30.4s run time
Failed to return result in 30000ms

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@ilamhs
Copy link
Copy Markdown
Contributor Author

ilamhs commented Feb 10, 2026

Verified that the tests failures are independent of this PR.

@Jackie-Jiang Jackie-Jiang added ingestion Related to data ingestion pipeline bugfix labels Feb 27, 2026
@Jackie-Jiang
Copy link
Copy Markdown
Contributor

I think the test failure is introduced by this PR. Please take another look:

2026-02-27T01:58:47.1087655Z [ERROR] Failures: 
2026-02-27T01:58:47.1089449Z [ERROR]   TlsIntegrationTest.testRealtimeSegmentUploadDownload:485 » IllegalState Failed to return result in 30000ms

@xiangfu0 xiangfu0 added bug Something is not working as expected and removed bugfix labels Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something is not working as expected ingestion Related to data ingestion pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants