Skip to content

PHOENIX-7795 : Tenant TTL using Tenant Views on Multi-Tenant Table #2400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
palashc wants to merge 5 commits into
base: master
Choose a base branch
from
+540 −4
Open

PHOENIX-7795 : Tenant TTL using Tenant Views on Multi-Tenant Table #2400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aff9926
PHOENIX-7795 : Tenant TTL using Global Views
Apr 6, 2026
b1289f2
spotless fix and rename class
Apr 7, 2026
7ddbad9
use tenant views
Apr 8, 2026
f898872
create rowKeyMatcher during compaction
Apr 9, 2026
4988a25
client side row key matcher generation
Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion phoenix-core-client/src/main/java/org/apache/phoenix/compile/CreateTableCompiler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ public MutationPlan compile(CreateTableStatement create) throws SQLException {
}
if (viewTypeToBe == ViewType.MAPPED && parentToBe.getPKColumns().isEmpty()) {
validateCreateViewCompilation(connection, parentToBe, columnDefs, pkConstraint);
} else if (where != null && viewTypeToBe == ViewType.UPDATABLE) {
} else if (viewTypeToBe == ViewType.UPDATABLE) {
rowKeyMatcher =
WhereOptimizer.getRowKeyMatcher(context, create.getTableName(), parentToBe, where);
}
Expand Down
22 changes: 19 additions & 3 deletions phoenix-core-client/src/main/java/org/apache/phoenix/compile/WhereOptimizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,12 +498,28 @@ public static byte[] getRowKeyMatcher(final StatementContext context,
PName tenantId = context.getConnection().getTenantId();
boolean isMultiTenant = tenantId != null && parentTable.isMultiTenant();

byte[] tenantIdBytes = tenantId == null
? ByteUtil.EMPTY_BYTE_ARRAY
: ScanUtil.getTenantIdBytes(schema, isSalted, tenantId, isMultiTenant, false);
// Gracefully handle tenant-id encoding failures (e.g., tenant-id type mismatch)
// so that view creation is not blocked; the view will simply have no ROW_KEY_MATCHER.
byte[] tenantIdBytes;
try {
tenantIdBytes = tenantId == null
? ByteUtil.EMPTY_BYTE_ARRAY
: ScanUtil.getTenantIdBytes(schema, isSalted, tenantId, isMultiTenant, false);
} catch (SQLException e) {
tenantIdBytes = ByteUtil.EMPTY_BYTE_ARRAY;
}
if (tenantIdBytes.length != 0) {
rowKeySlotRangesList.add(Arrays.asList(KeyRange.POINT.apply(tenantIdBytes)));
}
// For tenant views without a WHERE clause, return the tenant-id bytes as the
// ROW_KEY_MATCHER so that CompactionScanner can match rows to this view.
if (viewWhereExpression == null) {
if (rowKeySlotRangesList.isEmpty()) {
return ByteUtil.EMPTY_BYTE_ARRAY;
}
ScanRanges scanRange = ScanRanges.createSingleSpan(schema, rowKeySlotRangesList, null, false);
return scanRange.getScanRange().getLowerRange();
}
KeyExpressionVisitor visitor = new KeyExpressionVisitor(context, parentTable);
KeyExpressionVisitor.KeySlots keySlots = viewWhereExpression.accept(visitor);
if (keySlots == null) {
Expand Down
Loading