Skip to content

Conversation

@ArnavBalyan
Copy link
Member

Rationale for this change

  • Fixed the bug by correcting the bytes written value to 4 in VariantBuilder.appendFloat()
  • Added test to ensure we only write 5 bytes into the buffer (1 header + 4 float)
  • Should prevent any over-indexing the buffer

Are these changes tested?

  • Yes

Are there any user-facing changes?

  • Yes

Closes: #3317

@ArnavBalyan
Copy link
Member Author

cc @gszadovszky could you pls take a look

@gszadovszky gszadovszky merged commit 41f7359 into apache:master Sep 29, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VariantBuilder.appendFloat writes too many bytes

2 participants