GH-3315: Variant binary read does not take length into account #3333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gszadovszky
approved these changes
Sep 29, 2025
Contributor
Author
|
@gszadovszky Don't forget about this PR. |
Contributor
|
Sorry, @jerolba, I've indeed forgot about it. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Extracting Binary value from Variant, creating the ByteBuffer doesn't consider the length of the Binary element, creating a ByteBuffer with the size of the remaining Variant byte[]
What changes are included in this PR?
Creating the Binary, configure the limit of ByteBuffer using the calculated length
Are these changes tested?
Yes, in a test that creates Variant with multiple Binary elements that have more content after them.
Are there any user-facing changes?
No
Closes #3315