Skip to content

GH-3331: Track Column index page skip statistics during file read #3330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wgtmac merged 1 commit into from
Sep 25, 2025
+25 −3
Merged

GH-3331: Track Column index page skip statistics during file read #3330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnIndexFilterUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
*/
package org.apache.parquet.hadoop;

import static org.apache.parquet.hadoop.ParquetFileReaderMetrics.PagesIncluded;
import static org.apache.parquet.hadoop.ParquetFileReaderMetrics.PagesSkipped;

import it.unimi.dsi.fastutil.ints.IntArrayList;
import it.unimi.dsi.fastutil.ints.IntList;
import java.util.ArrayList;
Expand Down Expand Up @@ -129,14 +132,30 @@ public String toString() {
/*
* Returns the filtered offset index containing only the pages which are overlapping with rowRanges.
*/
static OffsetIndex filterOffsetIndex(OffsetIndex offsetIndex, RowRanges rowRanges, long totalRowCount) {
static OffsetIndex filterOffsetIndex(
OffsetIndex offsetIndex,
RowRanges rowRanges,
long totalRowCount,
org.apache.parquet.ParquetReadOptions options) {
IntList indexMap = new IntArrayList();
int pagesIncluded = 0;
int pagesSkipped = 0;
for (int i = 0, n = offsetIndex.getPageCount(); i < n; ++i) {
long from = offsetIndex.getFirstRowIndex(i);
if (rowRanges.isOverlapping(from, offsetIndex.getLastRowIndex(i, totalRowCount))) {
indexMap.add(i);
pagesIncluded++;
} else {
pagesSkipped++;
}
}

if (options != null && options.getMetricsCallback() != null) {
final ParquetMetricsCallback metricsCallback = options.getMetricsCallback();
metricsCallback.setValueInt(PagesIncluded.name(), pagesIncluded);
metricsCallback.setValueInt(PagesSkipped.name(), pagesSkipped);
}

return new FilteredOffsetIndex(offsetIndex, indexMap.toIntArray());
}

Expand Down
3 changes: 2 additions & 1 deletion parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1423,7 +1423,8 @@ private ColumnChunkPageReadStore internalReadFilteredRowGroup(
if (columnDescriptor != null) {
OffsetIndex offsetIndex = ciStore.getOffsetIndex(mc.getPath());

OffsetIndex filteredOffsetIndex = filterOffsetIndex(offsetIndex, rowRanges, block.getRowCount());
OffsetIndex filteredOffsetIndex =
filterOffsetIndex(offsetIndex, rowRanges, block.getRowCount(), options);
for (OffsetRange range : calculateOffsetRanges(filteredOffsetIndex, mc, offsetIndex.getOffset(0))) {
BenchmarkCounter.incrementTotalBytes(range.getLength());
long startingPos = range.getOffset();
Expand Down
4 changes: 3 additions & 1 deletion parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReaderMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ public enum ParquetFileReaderMetrics {
ReadThroughput("read throughput when reading Parquet file from storage (MB/sec)"),
DecompressTime("time spent in block decompression"),
DecompressSize("decompressed data size (MB)"),
DecompressThroughput("block decompression throughput (MB/sec)");
DecompressThroughput("block decompression throughput (MB/sec)"),
PagesIncluded("pages included due to column index filtering"),
PagesSkipped("pages skipped due to column index filtering");

private final String desc;

Expand Down