Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
import org.slf4j.LoggerFactory;

/**
* There was a bug (PARQUET-251) that caused the statistics metadata
* There was a bug (https://github.com/apache/parquet-java/issues/1433) that caused the statistics metadata
* for binary columns to be corrupted in the write path.
* <p>
* This class is used to detect whether a file was written with this bug,
Expand All @@ -38,7 +38,7 @@ public class CorruptStatistics {

private static final Logger LOG = LoggerFactory.getLogger(CorruptStatistics.class);

// the version in which the bug described by jira: PARQUET-251 was fixed
// the version in which the bug described by jira: (https://github.com/apache/parquet-java/issues/1433) was fixed
// the bug involved writing invalid binary statistics, so stats written prior to this
// fix must be ignored / assumed invalid
private static final SemanticVersion PARQUET_251_FIXED_VERSION = new SemanticVersion(1, 8, 0);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,13 @@
* FilterPredicate pred = or(eq(foo, 10), ltEq(bar, 17.0));
* </pre>
*/
// TODO: Support repeated columns (https://issues.apache.org/jira/browse/PARQUET-34)
// TODO: Support repeated columns (https://github.com/apache/parquet-java/issues/1452)
//
// TODO: Support filtering on groups (eg, filter where this group is / isn't null)
// TODO: (https://issues.apache.org/jira/browse/PARQUET-43)
// TODO: (https://github.com/apache/parquet-format/issues/261)

// TODO: Consider adding support for more column types that aren't coupled with parquet types, eg Column<String>
// TODO: (https://issues.apache.org/jira/browse/PARQUET-35)
// TODO: (https://github.com/apache/parquet-java/issues/1453)
public final class FilterApi {
private FilterApi() {}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
* <p>
* TODO: detect if a column is optional or required and validate that eq(null)
* TODO: is not called on required fields (is that too strict?)
* TODO: (https://issues.apache.org/jira/browse/PARQUET-44)
* TODO: (https://github.com/apache/parquet-java/issues/1472)
*/
public class SchemaCompatibilityValidator implements FilterPredicate.Visitor<Void> {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
* when there are type mismatches.
* <p>
* TODO: this has some overlap with {@link PrimitiveTypeName#javaType}
* TODO: (https://issues.apache.org/jira/browse/PARQUET-30)
* TODO: (https://github.com/apache/parquet-java/issues/1447)
*/
public class ValidTypeMap {
private ValidTypeMap() {}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public FilteringPrimitiveConverter(PrimitiveConverter delegate, ValueInspector[]
// TODO: this works, but
// TODO: essentially turns off the benefits of dictionary support
// TODO: even if the underlying delegate supports it.
// TODO: we should support it here. (https://issues.apache.org/jira/browse/PARQUET-36)
// TODO: we should support it here. (https://github.com/apache/parquet-java/issues/1392)
@Override
public boolean hasDictionarySupport() {
return false;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
* represent columns with a null value, and updates them accordingly.
* <p>
* TODO: We could also build an evaluator that detects if enough values are known to determine the outcome
* TODO: of the predicate and quit the record assembly early. (https://issues.apache.org/jira/browse/PARQUET-37)
* TODO: of the predicate and quit the record assembly early. (https://github.com/apache/parquet-java/issues/1455)
*/
public class IncrementallyUpdatedFilterPredicateEvaluator implements Visitor {
private static final IncrementallyUpdatedFilterPredicateEvaluator INSTANCE =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
* false otherwise (including when it is not known, which is often the case).
*/
// TODO: this belongs in the parquet-column project, but some of the classes here need to be moved too
// TODO: (https://issues.apache.org/jira/browse/PARQUET-38)
// TODO: (https://github.com/apache/parquet-java/issues/1458)
public class StatisticsFilter implements FilterPredicate.Visitor<Boolean> {

private static final boolean BLOCK_MIGHT_MATCH = false;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@
import org.slf4j.LoggerFactory;

// TODO: This file has become too long!
// TODO: Lets split it up: https://issues.apache.org/jira/browse/PARQUET-310
// TODO: Lets split it up: https://github.com/apache/parquet-java/issues/1835
public class ParquetMetadataConverter {

private static final TypeDefinedOrder TYPE_DEFINED_ORDER = new TypeDefinedOrder();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ public BytesInput decompress(BytesInput bytes, int decompressedSize) throws IOEx
InputStream is = codec.createInputStream(bytes.toInputStream(), decompressor);

// We need to explicitly close the ZstdDecompressorStream here to release the resources it holds to
// avoid off-heap memory fragmentation issue, see https://issues.apache.org/jira/browse/PARQUET-2160.
// avoid off-heap memory fragmentation issue, see https://github.com/apache/parquet-format/issues/398.
// This change will load the decompressor stream into heap a little earlier, since the problem it solves
// only happens in the ZSTD codec, so this modification is only made for ZSTD streams.
if (codec instanceof ZstandardCodec) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@

/**
* Read records from a Parquet file.
* TODO: too many constructors (https://issues.apache.org/jira/browse/PARQUET-39)
* TODO: too many constructors (https://github.com/apache/parquet-java/issues/1466)
*/
public class ParquetReader<T> implements Closeable {

Expand Down