Skip to content

GH-3294: Include optional profiles for release process #3297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fokko merged 1 commit into from
Sep 1, 2025
Merged

GH-3294: Include optional profiles for release process #3297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev/finalize-release
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ rc_tag="$release_tag-rc$2"
new_development_version="$3-SNAPSHOT"

git tag -am "Release Apache Parquet $release_version" "$release_tag" "$rc_tag"
./mvnw --batch-mode release:update-versions -DdevelopmentVersion="$new_development_version"
./mvnw --batch-mode -Pvector-plugins release:update-versions -DdevelopmentVersion="$new_development_version"
./mvnw -pl . versions:set-property -Dproperty=previous.version -DnewVersion="$release_version"
git commit -am 'Prepare for next development iteration'

Expand Down
2 changes: 1 addition & 1 deletion dev/prepare-release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,6 @@ new_development_version="$release_version-SNAPSHOT"
tag="apache-parquet-$release_version-rc$2"

./mvnw release:clean
./mvnw release:prepare -DskipTests -Darguments=-DskipTests -Dtag="$tag" "-DreleaseVersion=$release_version" -DdevelopmentVersion="$new_development_version"
./mvnw release:prepare -Pvector-plugins -DskipTests -Darguments=-DskipTests -Dtag="$tag" "-DreleaseVersion=$release_version" -DdevelopmentVersion="$new_development_version"
Copy link
Member

@pan3793 pan3793 Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this command perform compile and upload jars? vector-plugins requires JDK 17 to build

Copy link
Member

@wgtmac wgtmac Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's a good catch!

Copy link
Member

@pan3793 pan3793 Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is an alternative command that applies the version change to all modules (include optional modules)

./mvnw versions:set -DgenerateBackupPoms=false -DnewVersion=$release_version

Copy link
Member

@pan3793 pan3793 Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or, maybe you can consider releasing Parquet using a higher JDK version, with -release 8 to ensure Java 8 compatibility.

Copy link
Member Author

@ArnavBalyan ArnavBalyan Sep 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks thats a great find @pan3793!

I think the solution may depend on whether we want to include vector-plugins in our releases. It seems the current behaviour is not to include vector-plugins. Reverting this should continue maintaining this behaviour (not sure how it got included this time for 1.16 as vector-plugins is not included by default)

Optionally if we want to include vector-plugins in the releases, release script can be updated to include it conditionally on the JDK being used. Maybe have an automatic CI job for releases to avoid dev overhead.
@wgtmac @Fokko what do you think? Can take next steps accordingly thanks!

Copy link
Member

@wgtmac wgtmac Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a separate discussion to include vector-plugins in the release. Perhaps we can go with ./mvnw versions:set -DgenerateBackupPoms=false -DnewVersion=$release_version proposed by @pan3793

Copy link
Member Author

@ArnavBalyan ArnavBalyan Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Will raise the fix


echo "Finish staging binary artifacts by running: ./mvnw release:perform"