GH-3213: Add the configuration for ByteStreamSplit encoding #3214
+43
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
reviewed
May 14, 2025
| } | ||
|
|
||
| public SELF withByteStreamSplitEncoding(String columnPath, boolean enableByteStreamSplit) { | ||
| encodingPropsBuilder.withByteStreamSplitEncoding(columnPath, enableByteStreamSplit); |
Member
There was a problem hiding this comment.
Thanks for adding this! Could you please check if there is any test case covering it? If not, it would be good to add one to make sure it takes effect.
Contributor
Author
There was a problem hiding this comment.
Added the corresponding test. Thanks for your reminder
wgtmac
approved these changes
May 16, 2025
Member
|
Could you help rebase to re-trigger the failed CIs? I'll merge after all CIs are passed. |
Contributor
Author
|
@wgtmac Sorry for the late response. Would you still be available to take another look when you have a moment? |
Member
|
Thanks @joeyutong! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Add the configuration for ByteStreamSplit encoding for a specific column when building
ParquetWriterWhat changes are included in this PR?
A new config method
Are these changes tested?
No
Are there any user-facing changes?
Yes when building
ParquetWritere.g.Closes #3213