[python] Fix non-compact decimal and timestamp serialization in BinaryRow#7608
Open
plusplusjiajia wants to merge 5 commits intoapache:masterfrom
Open
[python] Fix non-compact decimal and timestamp serialization in BinaryRow#7608plusplusjiajia wants to merge 5 commits intoapache:masterfrom
plusplusjiajia wants to merge 5 commits intoapache:masterfrom
Conversation
plusplusjiajia
force-pushed
the
fix-decimal
branch
from
a6ca829 to
a2bf4f4
Compare
plusplusjiajia
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Previously python's
GenericRowSerializertreated all decimal and timestamp fields as compact format (value stored directly in the 8-byte fixed slot). Java's BinaryRow uses two formats:(offset << 32 | length)in fixed slot(offset << 32 | nanoOfMillisecond)in fixed slot