HDDS-14601. Allow clearing multipartInfoTable in abort when key doesn't exist in openKey/File table. #9746
+88
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t exist in openKey/File table.
ivandika3
reviewed
Feb 11, 2026
Contributor
ivandika3
left a comment
ivandika3
left a comment
There was a problem hiding this comment.
Thanks @ashishkumar50 for the fix, overall LGTM. Left one comment.
...main/java/org/apache/hadoop/ozone/om/request/s3/multipart/S3MultipartUploadAbortRequest.java
Outdated
Show resolved
Hide resolved
ivandika3
approved these changes
Feb 11, 2026
Contributor
ivandika3
left a comment
ivandika3
left a comment
There was a problem hiding this comment.
Thanks for the update. LGTM +1.
adoroszlai
reviewed
Feb 11, 2026
|
|
||
| if (multipartKeyInfo == null) { | ||
| throw new OMException("Abort Multipart Upload Failed: volume: " + | ||
| requestedVolume + "bucket: " + requestedBucket + "key: " + keyName, |
Contributor
There was a problem hiding this comment.
Not introduced in this patch, but not worth a separate PR either:
Suggested change
| requestedVolume + "bucket: " + requestedBucket + "key: " + keyName, | |
| requestedVolume + " bucket: " + requestedBucket + " key: " + keyName, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Allow removing entry from multipartInfoTable even though if key doesn't exist in openKey/File table during abort operation.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14601
How was this patch tested?
Unit test