HDDS-14595. Create new submodules for ozone debug/repair #9736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dombizita @errose28 @sarvekshayr please take a look |
sarvekshayr
reviewed
Feb 11, 2026
Contributor
sarvekshayr
left a comment
sarvekshayr
left a comment
There was a problem hiding this comment.
Thanks @adoroszlai for working on this.
Based on my understanding, I’ve reviewed and verified the changes, and they look good to me.
dombizita
approved these changes
Feb 11, 2026
Contributor
dombizita
left a comment
dombizita
left a comment
There was a problem hiding this comment.
Thanks for doing this in scope of the Java 17 changes, it looks good to me. There isn't any doc impact of this, right? I didn't find any place where we mentioned where the tools code is stored.
Contributor
Author
Only in the design doc, but that describes the state of code at that time, so I think it does not need to be updated. |
Contributor
Author
|
Thanks @dombizita, @sarvekshayr for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Ozone debug and repair tools use server-side internal code, which will require Java 17 after HDDS-14439. This PR creates new submodules
ozone-cli-debugandozone-cli-repairto remove the dependency on server-side modules fromozone-tools, thus keep CLI commands in that module usable with Java 8.Side-effect fixes:
ozone daemonlog, becauseLogLevelis inhdds-server-framework.ozone tenant, becauseTenantShellis inozone-cli-shell.DatabaseHelper.LOGbefore static initializer callsloadProperties(), which usesLOGin case of error.https://issues.apache.org/jira/browse/HDDS-14595
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/21830993207