HDDS-14454. Improve XceiverClientGrpc shutdown logic to ensure proper channel termination #9717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… channel termination.
ptlrs
force-pushed
the
HDDS-14454-XceiverClientGrpcClose
branch
from
a2dd999 to
af22ced
Compare
…channel termination handling.
yandrey321
reviewed
Feb 6, 2026
| try { | ||
| channel.awaitTermination(60, TimeUnit.MINUTES); | ||
| if (!nonTerminatedChannels.isEmpty()) { | ||
| ManagedChannel channel = nonTerminatedChannels.get(0); |
Contributor
Author
There was a problem hiding this comment.
This was due to the presence of synchronized methods and to workaround findbugs error
Run if [[ -s "target/$SCRIPT/summary.md" ]]; then
M M SWL: org.apache.hadoop.hdds.scm.XceiverClientGrpc.close() calls Thread.sleep() with a lock held At XceiverClientGrpc.java:[line 258]
Error: Process completed with exit code 1.
yandrey321
reviewed
Feb 6, 2026
| * to finish ongoing communication, then interrupts the connection anyway. | ||
| */ | ||
| @Override | ||
| public synchronized void close() { |
There was a problem hiding this comment.
with shutdown() instead of shutdownNow() we should not need synchronized here
yandrey321
reviewed
Feb 6, 2026
There was a problem hiding this comment.
we should use concurrent maps here, it should help with removing synchronized methods.
Contributor
Author
There was a problem hiding this comment.
The follow up PR #9718 addresses methods other than close
…cleaner channel termination handling." This reverts commit 7b6b0ee.
…onized modifier from close method.
Contributor
Author
|
Hi @jojochuang, could you please review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This change improves the closing mechanism for the Grpc client.
It closes all channels at the same time.
It waits only 5 seconds for closing the channels
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14454
How was this patch tested?
CI: https://github.com/ptlrs/ozone/actions/runs/21736799049