HDDS-14569. Remove support for upgrade actions that run outside of finalization #9716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated-By: Cursor
Contributor
Author
|
I'll fix the findbugs on my fork then mark it ready for review. |
Contributor
Author
|
CI should be green now, but there's been some github actions stability issues today. Looks like the run on my fork would have passed otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The upgrade framework currently support various hooks to run actions during the upgrade process. In practice we are only using upgrade actions that run when a layout feature is finalized (
ON_FINALIZE), which are the easiest to reason about. This PR removes support for adding upgrade actions to any other part of the upgrade flow so that we do not need to worry about testing and maintaining them as we iterate on the upgrade framework. This also reduces the chances of developer error when adding layout feature handling.What is the link to the Apache JIRA
HDDS-14569
How was this patch tested?
Existing tests are expected to pass to ensure there are no regressions in the simplification. No new functionality was added to be tested.