Skip to content

Conversation

@cchung100m
Copy link
Contributor

What changes were proposed in this pull request?

Add default javadoc:aggregate goal parameters to the root pom.xml

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-13145

How was this patch tested?

N/A

@cchung100m cchung100m marked this pull request as ready for review February 4, 2026 03:21
Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cchung100m for the patch.

How was this patch tested?

N/A

Can you please include screenshot of javadoc before/after? Also, please include the command to generate javadoc.

Comment on lines +2402 to +2403
<title>Hadoop Ozone Integration</title>
<packages>org.apache.hadoop.ozone*</packages>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hadoop appears in org.apache.hadoop.ozone for historical reason (Ozone started as sub-project of Hadoop), it's not related to integration with Hadoop. I don't think we need this grouping.

Comment on lines +2408 to +2409
<reportOutputDirectory>${project.build.directory}/site</reportOutputDirectory>
<destDir>ozone-main/api</destDir>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hadoop-project/api makes sense for Hadoop, because hadoop-project dir exists and contains a module. ozone-main module is not in the ozone-main dir, but in the root dir.

Isn't the default output directory fine?

Suggested change
<reportOutputDirectory>${project.build.directory}/site</reportOutputDirectory>
<destDir>ozone-main/api</destDir>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants