HDDS-15292. Reduce Thread.sleep usage in DiskBalancer tests.#10293
Open
slfan1989 wants to merge 1 commit into
Open
HDDS-15292. Reduce Thread.sleep usage in DiskBalancer tests.#10293slfan1989 wants to merge 1 commit into
slfan1989 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR reduces fixed
Thread.sleepusage in DiskBalancer tests.Some DiskBalancer tests used fixed sleeps to wait for asynchronous state changes or delayed cleanup. Fixed waits can make tests slower than necessary and may also introduce flakiness on slow or busy CI machines.
This change replaces those sleeps with condition-based waits using
GenericTestUtils.waitFor, so the tests continue as soon as the expected condition is met and fail with a timeout if it is not reached.Specifically, the tests now wait for explicit conditions such as:
UNHEALTHYorCLOSED.What is the link to the Apache JIRA
JIRA: HDDS-15292. Reduce Thread.sleep usage in DiskBalancer tests.
How was this patch tested?
Add Junit Test.