OFBIZ-13313#923
Conversation
Creates an interface for queryable objects, or objects that have a delegator. Allows for shorter queries. Thanks to Jacopo and Nicolas for the feedback.
Fixes the param name in javadoc
|
|
||
| enum OperationType { INSERT, UPDATE, DELETE } | ||
|
|
||
| Delegator getDelegator(); |
There was a problem hiding this comment.
This declaration is not required since it is an inherited method.
| import org.apache.ofbiz.entity.Delegator; | ||
|
|
||
| /** | ||
| * Interface used for the <code>EntityQuery</code> to set the delegator to yse for the query. |
There was a problem hiding this comment.
The Javadoc should just describe the capability of the interface without directly mentioning the classes that may use it (such as EntityQuery). There are also a few typos, such as: "yse", "easyer".
| public interface Queryable { | ||
|
|
||
| /** | ||
| * Gets the GenericEntityDelegator associated with this dispatcher |
There was a problem hiding this comment.
The Javadoc is not correct as it mentions GenericEntityDelegator rather than Delegator and it mentions "this dispatcher" which is out of context in this interface.
|
Thanks Gaetan, The introduction of the new interface makes sense and solves the concern I had. |
Fixes points raised by Jacopo. Thanks for the review.
Typo
|
|
Thanks for the review, all issues should have been fixed. |
|
Thanks Gaetan, it looks good to me now. |
nmalin
left a comment
nmalin
left a comment
There was a problem hiding this comment.
Hello Gaëtan,
I added some improvement on the following patch.
- Add Licence Apache 2.0 on header for DelegatorProvider
- GenericEntity implements DelegatorProvider
- Add test on EntityQuery to be sure that the DelegatorProvider and EntityQuery.use(DelegatorFactory) work well
Thanks for your work !
…FBIZ-13313) - Creates an interface for queryable objects, or objects that have a delegator. - Allows for shorter queries. Thanks to Jacopo and Nicolas for the feedback and review
|
3 participants
EntityQuery use dispatcher
Improved: Creates an interface for queryable objects, or objects that have a delegator.
(OFBIZ-13313)
Explanation: Allows the use of the dispatcher directly in the EntityQuery.
Created the Queryable interface to do so.
Thanks: to Jacopo and Nicolas for the feedback.