boards/boardctl: BOARDIOC_SPINLOCK missing some Conditional branch#18283
Merged
xiaoxiang781216 merged 1 commit intoapache:masterfrom Feb 2, 2026
Merged
Conversation
Contributor
Author
Where would be a good place to put this documentation? |
Add missing else branches to handle spinlock operations when no valid spinlock pointer is available. This fixes a regression in IRQ save/restore operations introduced by a previous refactoring of the spinlock control logic. Signed-off-by: hujun5 <hujun5@xiaomi.com>
bcdb84b to
9472c78
Compare
jerpelea
approved these changes
Feb 2, 2026
Contributor
Author
done |
xiaoxiang781216
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code only handles spinlock operations when
a spinlock is successfully obtained, but fails to provide fallback IRQ handling
for scenarios where spinlock retrieval fails or spinlock support is unavailable.
This PR adds the missing else branches to ensure proper IRQ state management
in edge cases, restoring the intended behavior prior to a recent refactoring
that inadvertently removed this safety path.
Summary
TEST