sched/spinlock: Replace critical_section with spinlock.#18270
Merged
xiaoxiang781216 merged 5 commits intoapache:masterfrom Feb 2, 2026
Merged
sched/spinlock: Replace critical_section with spinlock.#18270xiaoxiang781216 merged 5 commits intoapache:masterfrom
xiaoxiang781216 merged 5 commits intoapache:masterfrom
Conversation
Replace critical_section with spinlock or mutex. The benefits of doing this are: 1. It makes the code logic clearer, with different resources protected by different locks. 2. It improves system responsiveness and avoids contention issues caused by acquiring the same large lock. Signed-off-by: wangzhi16 <wangzhi16@xiaomi.com>
The benefits of doing this are: 1. It makes the code logic clearer, with different resources protected by different locks. 2. It improves system responsiveness and avoids contention issues caused by acquiring the same large lock. Signed-off-by: wangzhi16 <wangzhi16@xiaomi.com>
Replace critical_section with spinlock. The benefits of doing this are: 1. It makes the code logic clearer, with different resources protected by different locks. 2. It improves system responsiveness and avoids contention issues caused by acquiring the same large lock. Signed-off-by: wangzhi16 <wangzhi16@xiaomi.com>
The benefits of doing this are: 1. It makes the code logic clearer, with different resources protected by different locks. 2. It improves system responsiveness and avoids contention issues caused by acquiring the same large lock. Signed-off-by: wangzhi16 <wangzhi16@xiaomi.com>
xiaoxiang781216
previously approved these changes
Jan 30, 2026
To skip the style issue: Error: /home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/phy62xx/irq.c:194:5: error: Mixed case identifier found Error: /home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/phy62xx/irq.c:196:5: error: Mixed case identifier found Error: /home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/phy62xx/irq.c:199:5: error: Mixed case identifier found Error: /home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/phy62xx/phyplus_wdt.c:61:28: error: Mixed case identifier found Error: /home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/phy62xx/phyplus_wdt.c:104:2: error: Mixed case identifier found Error: /home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/phy62xx/phyplus_wdt.c:162:50: error: Mixed case identifier found Signed-off-by: wangzhi16 <wangzhi16@xiaomi.com>
48cf7de to
6e81d5a
Compare
Donny9
approved these changes
Feb 2, 2026
xiaoxiang781216
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR aggregates three closely related architecture-level changes that optimize critical-section handling on various ARM platforms by replacing broad critical-section locks with more targeted spinlocks or mutexes. The goal is to clarify locking responsibilities, reduce contention, and improve system responsiveness.
Included Commits
b4f7a03— arm64/common: Critical Section Optimization. — wangzhi16 (2025-06-20)critical_sectionusage with spinlocks to protect distinct resources.23f98ce— arm/phy62xx: Critical Section Optimization. — wangzhi16 (2025-06-20)90be4bc— arm/rtl8720c: Critical Section Optimization. — wangzhi16 (2025-06-20)critical_sectionwith spinlock or mutex where appropriate in RTL8720C driver code.Rationale
critical_sectionusage with per-resource spinlocks/mutexes:Impact
enter_critical_section/leave_critical_sectionwith spinlocks/mutexes.please ignore the mix case warning:
Testing
./tools/configure.sh -l amrv7a:smp make -j$(nproc)PASS