boards/arm: fix div64_const not compatible for pre-process macro#18253
Closed
wangzhi16 wants to merge 1 commit intoapache:masterfrom
Closed
boards/arm: fix div64_const not compatible for pre-process macro#18253wangzhi16 wants to merge 1 commit intoapache:masterfrom
wangzhi16 wants to merge 1 commit intoapache:masterfrom
Conversation
from board/cxd56_automount.c:34: board/cxd56_automount.c:94:19: error: braced-group within expression allowed only inside a function 94 | .ddelay = MSEC2TICK(CONFIG_CXD56_SDCARD_AUTOMOUNT_DDELAY), | ^~~~~~~~~ board/cxd56_automount.c:95:19: error: braced-group within expression allowed only inside a function 95 | .udelay = MSEC2TICK(CONFIG_CXD56_SDCARD_AUTOMOUNT_UDELAY), | ^~~~~~~~~ Compile-time assignment uses regular division, and runtime assignment uses high-performance division Signed-off-by: wangzhi16 <wangzhi16@xiaomi.com>
wangzhi16
requested review from
Donny9,
GUIDINGLI and
jerpelea
as code owners
linguini1
requested changes
Jan 29, 2026
Contributor
linguini1
left a comment
linguini1
left a comment
There was a problem hiding this comment.
Please make sure the PR adheres to the contributing guidelines.
Testing should include logs where possible and should be an actual test of the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
from board/cxd56_automount.c:34:
board/cxd56_automount.c:94:19: error: braced-group within expression allowed only inside a function
94 | .ddelay = MSEC2TICK(CONFIG_CXD56_SDCARD_AUTOMOUNT_DDELAY),
| ^~~~~~~~~
board/cxd56_automount.c:95:19: error: braced-group within expression allowed only inside a function
95 | .udelay = MSEC2TICK(CONFIG_CXD56_SDCARD_AUTOMOUNT_UDELAY),
| ^~~~~~~~~
Compile-time assignment uses regular division, and runtime assignment uses high-performance division
Impact
None
Testing
ostest PASS