net/wireless: fix compile warning issue for wireless #17652
Merged
+39
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HedongGao
requested review from
antmerlino,
jerpelea and
xiaoxiang781216
as code owners
github-actions
bot
added
Area: Drivers
linguini1
approved these changes
Dec 23, 2025
Contributor
Author
|
This pr should CI with another one together! |
Contributor
@HedongGao please remove the merge patch from pr. |
fix tasking compile warning isssue warnning log: unused variable "IEEE802154_STATUS_STRING" Signed-off-by: gaohedong <gaohedong@xiaomi.com>
Contributor
Author
DONE |
anchao
approved these changes
Dec 24, 2025
xiaoxiang781216
approved these changes
Dec 24, 2025
linguini1
previously requested changes
Dec 24, 2025
Contributor
linguini1
left a comment
linguini1
left a comment
There was a problem hiding this comment.
It looks like there are multiple places where it must be renamed still.
linguini1
dismissed
their stale review
Realizing the other PR which completes the renaming is another repo. My apologies!
linguini1
approved these changes
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
IEEE802154_STATUS_STRING is defined in the .h file, which will generate compilation warning information under some compilers. Moved the position of the variable to fix this issue. At the same time, changed the name of the variable to unify the code style.
Impact
This change has rename
static const char *IEEE802154_STATUS_STRING[]toFAR const char *g_ieee802154_status_string[]. It will affect wireless/ieee802154/i8sak/*.c in nuttx-apps repository which used this var. So, I submitted another patch to the nuttx apps repository:apps pr
Testing
gcc compiler has no warning infor for
nuttx-apps/wireless/ieee802154/i8sak, but tasking compiler has warning information.warnning log: unused variable "IEEE802154_STATUS_STRING"
After the issue is fixed, the warning dispeared, and the results compiled with both compilers are normal.
PRs without testing information will not be accepted. We will
request test logs.