Avoid using of javac-related instances outside of the javac context that created them.#9127
Merged
mbien merged 1 commit intoapache:masterfrom Jan 20, 2026
Conversation
…hat created them.
Member
|
milestone was set to NB 30, will change it to NB 29 because it is still pre-freeze and this bigfix is fairly isolated/low risk IMO. |
matthiasblaesing
approved these changes
Jan 8, 2026
Contributor
matthiasblaesing
left a comment
There was a problem hiding this comment.
Tested with a minimal JSF project and the hint is correctly generated for a ManagedBean and its scoping annotation javax.faces.bean.RequestScoped. Also correctly the hint is not generated for Named bean with javax.enterprise.context.RequestScoped scope.
The implementation looks sane to me. Thank you!
Member
|
merging for NB 29 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up to:
#9042
fixing two Fixes in
enterprise/web.jsfto not keep javac-related instances across javac contexts. I tried to minimize the disruption in the code, although I suspect that merging these two hints into one would be possible.^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)