Skip to content

Conversation

@haidubogdan
Copy link
Contributor

@haidubogdan haidubogdan commented Dec 31, 2025

Follow-up of env file support.
It seems to be a relevant thing during development.
All generated antlr parser files should have the license header to not block development while doing license checks run.


^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

@haidubogdan haidubogdan force-pushed the t_license_header_for_env_antlr_generated_files branch from bce3c08 to 82feda0 Compare December 31, 2025 05:54
@mbien mbien added the Editor label Dec 31, 2025
@matthiasblaesing matthiasblaesing added this to the NB29 milestone Dec 31, 2025
@matthiasblaesing
Copy link
Contributor

This change is good and ensures the license header is in place. If this came up on a rat run, then this is not strictly necessary though. rat should be run on a clean checkout.

@apache apache locked and limited conversation to collaborators Dec 31, 2025
@apache apache unlocked this conversation Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants