Skip to content

Conversation

@mbien
Copy link
Member

@mbien mbien commented Sep 23, 2025

key FileChooser (e.g terminal remote connection) will now also show openssh keys which have a longer key header

found this issue while testing #8848 and noticed that the file chooser didn't list my keys (both RSA and EC, created using OpenSSH)

will now also show openssh keys which have a longer key header
@mbien mbien added this to the NB28 milestone Sep 23, 2025
@mbien mbien added UI User Interface ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Sep 23, 2025
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only eyeballed this, but looks ok to me.

Maybe it would have been more readable, to just raise the buffer to 40 bytes, switch to try-with-resource and switch to DOTALL matching.

@mbien
Copy link
Member Author

mbien commented Sep 25, 2025

Maybe it would have been more readable, to just raise the buffer to 40 bytes, switch to try-with-resource and switch to DOTALL matching.

that was my original impl. But I wanted to avoid reading into the key with string operations in UI code. I don't want to see parts of the key in Strings or heap dumps unless there is no other way of doing that. I hope its still simple enough.

@mbien mbien merged commit 096854f into apache:master Sep 25, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) UI User Interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants