Skip to content

Conversation

@dasTanmoy0096
Copy link

Remove bundled default -J heap/GC arguments from the launcher and add a new netbeans.serverVmOptions setting (array) so users can supply additional JVM arguments. The extension reads the setting and prepends each entry with -J when launching the language server; changes trigger a restart. This makes VM options configurable per-machine and avoids forcing defaults. Fixes issues such as:- #16


Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Is this PR squashed?
  2. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  3. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

…ts from nbcode.conf

The default VM options can conflict with environment variables such those a user may provide through JAVA_TOOL_OPTIONS.
It's better if we don't provide any default options and let a user provide their own through this setting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant