-
Notifications
You must be signed in to change notification settings - Fork 143
Update to Jetty 12.1 #1748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Jetty 12.1 #1748
Conversation
This affects both Server used for Tests and Jetty Transport (for HTTP) This increases Java requirements to 17 for Jetty Transport
| if (putTask.getDataPath() != null) { | ||
| channel = Files.newByteChannel(putTask.getDataPath(), StandardOpenOption.READ); | ||
| } else { | ||
| // TODO: support rewind for retries when using InputStream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cstamas Any idea how to implement that with minimal effort?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 58 to 63 in 1f01b66
| public InputStream newInputStream() throws IOException { | |
| if (dataPath != null) { | |
| return Files.newInputStream(dataPath); | |
| } | |
| return new ByteArrayInputStream(dataBytes); | |
| } |
PutTask carries either a file (File in Resolver 1 or Path in Resolver 2) or handful of bytes (as byte[]). Also is a final class, so maybe we just need to expose this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Came up with a simpler solution based on Supplier<ReadableByteChannel> in 82f6bda.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improvement tracked in #1751
|
@kwin Please assign appropriate label to PR according to the type of change. |
This affects both Server used for Tests and Jetty Transport (for HTTP) This increases Java requirements to 17 for Jetty Transport
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.