Skip to content

sign deprecation #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
elharo wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

sign deprecation #1437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4abc345
sign deprecation
elharo Nov 28, 2025
c25d3d5
Merge branch 'master' into feature-A
elharo Nov 28, 2025
9380f01
revert
elharo Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...manager/src/test/java/org/apache/maven/shared/release/phase/IsScmTagParametersEquals.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
import org.mockito.ArgumentMatcher;

/**
* Mockito constraint to compare tags since it has no equals method.
* Mockito constraint to compare tags since ScmTagParameters has no equals method.
*
* @author <a href="mailto:olamy@apache.org">olamy</a>
*/
Expand All @@ -38,6 +38,6 @@ public boolean matches(ScmTagParameters stp) {
return stp.getMessage().equals(this.scmTagParameters.getMessage())
&& stp.isRemoteTagging() == this.scmTagParameters.isRemoteTagging()
&& stp.isPinExternals() == this.scmTagParameters.isPinExternals()
&& stp.isSign() == this.scmTagParameters.isSign();
&& stp.getSignOption() == this.scmTagParameters.getSignOption();
}
}
3 changes: 2 additions & 1 deletion ...-release-manager/src/test/java/org/apache/maven/shared/release/phase/ScmTagPhaseTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import java.util.List;

import org.apache.maven.project.MavenProject;
import org.apache.maven.scm.CommandParameters;
import org.apache.maven.scm.ScmException;
import org.apache.maven.scm.ScmFile;
import org.apache.maven.scm.ScmFileSet;
Expand Down Expand Up @@ -102,7 +103,7 @@ void testTag() throws Exception {
builder.setScmSignTags(true);

ScmTagParameters expectedTagParameters = new ScmTagParameters("[my prefix] copy for tag release-label");
expectedTagParameters.setSign(true);
expectedTagParameters.setSignOption(CommandParameters.SignOption.FORCE_SIGN);

ScmFileSet fileSet = new ScmFileSet(rootProject.getFile().getParentFile());

Expand Down
Loading