fix: fix addParentPoms=true causes repositories to be ignored.#1585
Draft
k-wall wants to merge 1 commit intoapache:masterfrom
Draft
fix: fix addParentPoms=true causes repositories to be ignored.#1585k-wall wants to merge 1 commit intoapache:masterfrom
k-wall wants to merge 1 commit intoapache:masterfrom
Conversation
Signed-off-by: Keith Wall <kwall@apache.org>
k-wall
commented
Feb 4, 2026
| ProjectBuildingRequest buildingRequest = | ||
| new DefaultProjectBuildingRequest(session.getProjectBuildingRequest()); | ||
| buildingRequest.setProcessPlugins(false); | ||
| if (getProject().getRemoteArtifactRepositories() != null |
Author
There was a problem hiding this comment.
Author
|
Anyone? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR - I'm hoping for some feedback on whether the approach taken is reasonable or not. If yes, I'll add tests and then undraft the PR. Thank you for the attention.
Draft fix for #1028 - If
addParentPomsis true, the plugin fails to respect any remote repositories declare in the POM leading to a build failure when resolving artefacts that do not exist in Central.When the failure occurs, it fails as follows. (Note: In this case the org.apache.kafka:kafka-clients:pom:4.2.0 is available in staging repo which is referenced in the project's POM).
This change propagates the remote repositories from the project to the
ProjectBuildingRequestused build the project for the parent artefacts. The approach was inspired by https://github.com/apache/maven-javadoc-plugin/blob/ace4fe073378474b53296bd8c7a3f4a3faa44e17/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java#L2364I don't know the Maven API well, so I'm hoping someone can give me a thumbs up that the approach is generally in the right direction. I'll then spend time adding test case(s).
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.