Update DirectoryTaxonomyReader.java to let getBulkPath use cache#15711
Merged
msokolov merged 4 commits intoapache:mainfrom Mar 27, 2026
Merged
Update DirectoryTaxonomyReader.java to let getBulkPath use cache#15711msokolov merged 4 commits intoapache:mainfrom
msokolov merged 4 commits intoapache:mainfrom
Conversation
epotyom
approved these changes
Feb 17, 2026
Contributor
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
msokolov
approved these changes
Mar 27, 2026
Contributor
msokolov
left a comment
There was a problem hiding this comment.
thanks, LGTM, I'll merge now
gsmiller
pushed a commit
that referenced
this pull request
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
getBulkPathis callinggetPathFromCachebut never uses the value.Solution
Use the output of
getPathFromCacheand only sort uncached ordinalsFixes #15705
Testing
python src/python/localrun.py -source wikimediumall