Skip to content

Conversation

@Kami
Copy link
Member

@Kami Kami commented Mar 2, 2025

Description

This is an attempt to improve existing build + dist + install checks in an attempt to automatically catch issues such as the one reported in #2047.

Keep in mind though that it's not yet fully clear to me why the existing checks didn't catch that issue (possibly something related to the execution environment there).

Kami added 2 commits March 2, 2025 17:44
Also use python -m build to build sdist tarball as well and
add addition sanity checks to the scripts.
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.40%. Comparing base (42bf483) to head (abda09e).
⚠️ Report is 56 commits behind head on trunk.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk    #2054   +/-   ##
=======================================
  Coverage   83.40%   83.40%           
=======================================
  Files         353      353           
  Lines       81684    81684           
  Branches     8631     8631           
=======================================
  Hits        68124    68124           
  Misses      10738    10738           
  Partials     2822     2822           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kami Kami force-pushed the chore/more_install_checks branch from 15132ef to 3df72b7 Compare March 2, 2025 17:00
@Kami Kami added this to the v3.9.0 milestone Mar 2, 2025
@Kami Kami added the build label Mar 2, 2025
@Kami Kami merged commit 161e446 into trunk Mar 2, 2025
17 checks passed
@Kami Kami deleted the chore/more_install_checks branch March 2, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants