Add VPC IP and Elastic IP to ECS node as private and public IP #1954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicwicker
changed the title
vicwicker
changed the title
vicwicker
changed the title
As per documentation [1], the InnerIpAddress field is only relevant when the node network type is set to classic. If the node is within a VPC, the field used is PrivateIpAddress within VpcAttributes. In addition, elastic ips in field EipAddress are also public ips. They differ from other public ips in that they are static and stay the same once allocated. Fields EipAddress and VpcAttributes are already returned in the response as part of the "extra" field of the node object. This is however not consistent with the other drivers as these fields are also public and private ip addresses, respectively. [1] https://www.alibabacloud.com/help/en/ecs/developer-reference/api-describeinstances
Codecov Report
@@ Coverage Diff @@
## trunk #1954 +/- ##
=======================================
Coverage 83.19% 83.19%
=======================================
Files 353 353
Lines 81381 81387 +6
Branches 8583 8586 +3
=======================================
+ Hits 67701 67707 +6
Misses 10874 10874
Partials 2806 2806
|
asfgit
pushed a commit
that referenced
this pull request
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per documentation [1], the InnerIpAddress field is only relevant
when the node network type is set to classic. If the node is within
a VPC, the private IP is returned by the VpcAttributes/PrivateIpAddress.
In addition, elastic IPs in field EipAddress are also public ips.
They differ from other public IPs in that they are static and stay
the same once allocated.
Fields EipAddress and VpcAttributes are already returned in the response
as part of the "extra" field of the node object. This is however not
consistent with other drivers as these fields are also public and
private IP addresses, respectively.
[1] https://www.alibabacloud.com/help/en/ecs/developer-reference/api-describeinstances
Status
Checklist (tick everything that applies)