Skip to content

Fix inappropriate length comparison #1940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kami merged 2 commits into from
Sep 13, 2023
Merged

Fix inappropriate length comparison #1940

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
096303a
Comment: Fixed inappropriate length comparison.
munahaf Aug 17, 2023
87eda10
Merge branch 'trunk' into Inappropriate_Logic-4nttcis.py1578107171730…
Kami Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions libcloud/common/nttcis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2235,12 +2235,12 @@ class XmlListConfig(list):

def __init__(self, elem_list):
for element in elem_list:
if element is not None:
if element is not None and len(element) > 1:
# treat like dict
if len(element) >= 0 or element[0].tag != element[1].tag:
if element[0].tag != element[1].tag:
self.append(XmlDictConfig(element))
# treat like list
elif element[0].tag == element[1].tag:
else:
# property refers to an element used repeatedly
# in the XML for data centers only
if "property" in element.tag:
Expand Down